Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dpnp.nan_to_num() #1966

Merged
merged 15 commits into from
Aug 9, 2024
Merged

Implement dpnp.nan_to_num() #1966

merged 15 commits into from
Aug 9, 2024

Conversation

vlad-perevezentsev
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev commented Aug 2, 2024 •
edited
Loading

This PR suggests implementing new math function dpnp.nan_to_num() through dpnp functions like dpnp.isposinf(), dpnp.isneginf() dpnp.isnan() and dpnp.where(). Also added new tests covering cases not implemented in CuPy tests

Performance measurements on PVC
image

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Aug 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Aug 5, 2024
View reviewed changes
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
tests/test_mathematical.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Aug 6, 2024
View reviewed changes
tests/test_sycl_queue.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Aug 6, 2024
View reviewed changes
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
tests/third_party/cupy/math_tests/test_misc.py Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments from me, thank you @vlad-perevezentsev

@antonwolfy antonwolfy merged commit cb31797 into master Aug 9, 2024
23 of 31 checks passed
@antonwolfy antonwolfy deleted the impl_nan_to_num branch August 9, 2024 16:07
github-actions bot added a commit that referenced this pull request Aug 9, 2024
@github-actions
Implement dpnp.nan_to_num() (#1966)
9a38603 
* Implement dpnp.nan_to_num()

* Update cupy tests for nan_to_num()

* Add dpnp tests

* Skip test_nan_to_num_scalar_nan

* Applied review comments

* Add more tests for nan_to_num()

* Improve perfomance using out empty_like array

* Add checks for nan, posinf, neginf args

* Add type check for nan, posinf and neginf

* Update tests

* Add support boolean type cb31797
antonwolfy pushed a commit that referenced this pull request Aug 9, 2024
@vlad-perevezentsev @antonwolfy
Implement dpnp.nan_to_num() (#1966)
78b766d 
* Implement dpnp.nan_to_num()

* Update cupy tests for nan_to_num()

* Add dpnp tests

* Skip test_nan_to_num_scalar_nan

* Applied review comments

* Add more tests for nan_to_num()

* Improve perfomance using out empty_like array

* Add checks for nan, posinf, neginf args

* Add type check for nan, posinf and neginf

* Update tests

* Add support boolean type
antonwolfy added a commit that referenced this pull request Aug 12, 2024
@antonwolfy @vlad-perevezentsev @vtavana
Leverage on dpctl implementation of shape.setter (#1975)
4a23239 
* Leverage on dpctl shape.setter for any input

* Mute false-positive pylint issue

* Remove disable=invalid-unary-operand-type since resolved with pylint 3.2.6

* Implement `dpnp.nan_to_num()` (#1966)

* Implement dpnp.nan_to_num()

* Update cupy tests for nan_to_num()

* Add dpnp tests

* Skip test_nan_to_num_scalar_nan

* Applied review comments

* Add more tests for nan_to_num()

* Improve perfomance using out empty_like array

* Add checks for nan, posinf, neginf args

* Add type check for nan, posinf and neginf

* Update tests

* Add support boolean type

* Apply suggestions from code review

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>

* Corrected a link in docstring

* Updated wring indention

---------

Co-authored-by: vlad-perevezentsev <vladislav.perevezentsev@intel.com>
Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Aug 12, 2024
@github-actions @vlad-perevezentsev
Leverage on dpctl implementation of shape.setter (#1975)
9e39091 
* Leverage on dpctl shape.setter for any input

* Mute false-positive pylint issue

* Remove disable=invalid-unary-operand-type since resolved with pylint 3.2.6

* Implement `dpnp.nan_to_num()` (#1966)

* Implement dpnp.nan_to_num()

* Update cupy tests for nan_to_num()

* Add dpnp tests

* Skip test_nan_to_num_scalar_nan

* Applied review comments

* Add more tests for nan_to_num()

* Improve perfomance using out empty_like array

* Add checks for nan, posinf, neginf args

* Add type check for nan, posinf and neginf

* Update tests

* Add support boolean type

* Apply suggestions from code review

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>

* Corrected a link in docstring

* Updated wring indention

---------

Co-authored-by: vlad-perevezentsev <vladislav.perevezentsev@intel.com>
Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> 4a23239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy