Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation of dpnp.argwhere #2000

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Add implementation of dpnp.argwhere #2000

merged 6 commits into from
Aug 19, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 19, 2024

The PR proposes to implement dpnp.argwhere function.

The implementation is done through existing python calls.
Existing third party tests are unmuted. And new tests are added to cover different use cases.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Aug 19, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 762d477 into master Aug 19, 2024
37 of 45 checks passed
@antonwolfy antonwolfy deleted the impl-agrwhere branch August 19, 2024 13:49
github-actions bot added a commit that referenced this pull request Aug 19, 2024
* Add implementation of dpnp.argwhere()

* Added new tests and updated existing ones

* Applied pre-commit hooks

* Fix broken link in description 762d477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants