Extend gesv_impl/gesv_batch_impl for work with oneMKL Interfaces
#2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-perevezentsev
requested review from
antonwolfy,
npolina4 and
vtavana
as code owners
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Aug 19, 2024
antonwolfy
reviewed
Aug 20, 2024
antonwolfy
approved these changes
Aug 20, 2024
github-actions bot
added a commit
that referenced
this pull request
Aug 21, 2024
…2001) * Implement batch solve via getrf_batch and getrs_batch * Pass sycl::queue by reference for getrs/getrs_batch * Extend gesv_impl to use onemkl interfaces * Reduce code duplication in gesv_impl * Extend gesv_batch_impl to use onemkl interfaces * Remove getrs_batch implementation * Pass correct batch_strides to gesv_batch_fn * Reduce dublicate code for gesv_impl * Replace maybe_unused to if defined/else * Expand comments for trans parameter --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> f22a4cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests extending the implementation of
gesv_implandgesv_batch_implfordpnp.linalg,solveto work with OneMKL Interfaces becauseoneapi:mkl::lapack:gesvis missing there and will only be added in version 2025.1, adding logic to callgesv/gesv_batchviagetrf/getrs,getrf_batch/getrs_batch