Add implementation of dpnp.real_if_close
#2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vlad-perevezentsev
approved these changes
Aug 20, 2024
github-actions bot
added a commit
that referenced
this pull request
Aug 20, 2024
* Add implementation of dpnp.real_if_close * Updated third party tests * Added CFD tests * Add more tests * State default value in the description * Add negative test for 'tol' keyword * Add proper link description per review comment fbc798a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to implement
dpnp.real_if_closefunction.The implementation is done through existing python calls.
Existing third party tests are unmuted. And new tests are added to cover different use cases.