Add copy keyword to dpnp.asarray and align dpnp.array(..., copy=None) with NumPy 2.0
#2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
antonwolfy
force-pushed
the
align-copy-keyword-in-array-asarray-witn-numpy-2.0
branch
from
cbb7669
to
5dcf351
Compare
vtavana
reviewed
Aug 21, 2024
Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>
vtavana
approved these changes
Aug 21, 2024
antonwolfy
deleted the
align-copy-keyword-in-array-asarray-witn-numpy-2.0
branch
github-actions bot
added a commit
that referenced
this pull request
Aug 21, 2024
…None)` with NumPy 2.0 (#2006) * Add copy keyword to dpnp.asarray() and align dpnp.array(..., copy=None) with NumPy 2.0 * Updated third party tests * Pass copy=None to dpnp.array() from matmul implementation * Update dpnp/dpnp_utils/dpnp_utils_linearalgebra.py Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> --------- Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> 737d2b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
copykeyword behavior changes innumpy.asarrayandnumpy.arrayduring migration to NumPy 2.0 (see link for details).The PR propose to align
dpnp.arraybehavior with the changes done fornumpy.asarray.And also to add
copykeyword todpnp.asarray, which has been already present indpctl.tensorinterface for a time.All the impacted tests are updated to cover any numpy version between 1.23 and 2.0.