Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of dpnp.append and dpnp.asarray_chkfinite #2015

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Implementation of dpnp.append and dpnp.asarray_chkfinite #2015

merged 6 commits into from
Aug 29, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Aug 28, 2024

In this PR,

  1. dpnp.append and dpnp.asarray_chk_finite are implemented
  2. order keyword in eye, ones, zeros, full, and empty functions in NumPy only supports "C" and "F", and dpnp does not have any limitation in this regard. Docstring of these functions in dpnp is updated to reflect this fact.
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Aug 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 28, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review August 28, 2024 19:02
npolina4
npolina4 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@npolina4 npolina4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana!

@vtavana vtavana merged commit 838dbda into master Aug 29, 2024
37 of 46 checks passed
@vtavana vtavana deleted the impl_append branch August 29, 2024 18:35
github-actions bot added a commit that referenced this pull request Aug 29, 2024
@github-actions
Implementation of dpnp.append and dpnp.asarray_chkfinite (#2015)
425338f 
* implement dpnp.append

* implement dpnp.asarray_chkfinite

* remove limitation for array creation functions

* fix pre-commit

* fix failed tests

* add no copy test 838dbda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npolina4 npolina4 npolina4 approved these changes

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @npolina4