Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dpnp.ravel_multi_index and dpnp.unravel_index #2022

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Implement dpnp.ravel_multi_index and dpnp.unravel_index #2022

merged 4 commits into from
Sep 10, 2024

Conversation

npolina4
Copy link
Collaborator

@npolina4 npolina4 commented Sep 4, 2024

implemented dpnp.ravel_multi_index and dpnp.unravel_index.
Added tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vtavana
vtavana reviewed Sep 9, 2024
View reviewed changes
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
tests/test_indexing.py Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
vtavana
vtavana approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @npolina4!

@npolina4 npolina4 merged commit e5506bf into master Sep 10, 2024
36 of 46 checks passed
@npolina4 npolina4 deleted the impl_unravel_index branch September 10, 2024 04:01
github-actions bot added a commit that referenced this pull request Sep 10, 2024
@github-actions
Implement dpnp.ravel_multi_index and dpnp.unravel_index (#2022)
c1897a1 
* implement dpnp.ravel_multi_index and dpnp.unravel_index

* Applied review comments e5506bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npolina4 @vtavana