Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper handling of unput array of usm_ndarray type in dpnp.ix_ #2047

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Add proper handling of unput array of usm_ndarray type in dpnp.ix_ #2047

merged 5 commits into from
Sep 16, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Sep 16, 2024 •
edited
Loading

The PR is intended to resolve an exception raised while passing input array of usm_ndarray type.
The test is added to cover the scenario. Also small improvements to existing tests are implemented.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vlad-perevezentsev
vlad-perevezentsev approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 6314346 into master Sep 16, 2024
35 of 46 checks passed
@antonwolfy antonwolfy deleted the handle-usm_ndarray-in-ix_ branch September 16, 2024 13:46
antonwolfy added a commit that referenced this pull request Sep 16, 2024
@antonwolfy
Add proper handling of unput array of usm_ndarray type in dpnp.ix_ (
56d87d6 
#2047)

* Proper handling of input array as dpctl.tensor.usm_ndarray

* Update a page for Indexing routines

* Move dpnp.ix_ tests to keep lexycographical order

* Add tests to cover faulty use case

* Added entry to changelog
@antonwolfy antonwolfy mentioned this pull request Sep 16, 2024
Merged
6 tasks
github-actions bot added a commit that referenced this pull request Sep 16, 2024
@github-actions
Add proper handling of unput array of usm_ndarray type in dpnp.ix_ (
7068211 
#2047)

* Proper handling of input array as dpctl.tensor.usm_ndarray

* Update a page for Indexing routines

* Move dpnp.ix_ tests to keep lexycographical order

* Add tests to cover faulty use case

* Added entry to changelog 6314346
github-actions bot added a commit that referenced this pull request Sep 16, 2024
@github-actions
Backport gh-2047 51ba1a3
e1b8a89
antonwolfy added a commit that referenced this pull request Sep 16, 2024
@antonwolfy
Add proper handling of unput array of usm_ndarray type in dpnp.ix_ (
c4be394 
#2047) (#2050)

* Proper handling of input array as dpctl.tensor.usm_ndarray

* Update a page for Indexing routines

* Move dpnp.ix_ tests to keep lexycographical order

* Add tests to cover faulty use case

* Added entry to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev