Resolve crash identified in backend implementation of dpnp.choose
#2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
force-pushed
the
resolve-crash-in-dpnp.choose
branch
from
b722359
to
be09527
Compare
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
antonwolfy
changed the title
dpnp.choosedpnp.choose
vtavana
approved these changes
Sep 19, 2024
vtavana
pushed a commit
that referenced
this pull request
Sep 19, 2024
…2063) * Add memory copy to device memory * Keep extra memcopy only for the result array * Add missing memory copy from host to device memory * Applied pre-commit formatting * Updated changelog * Add empty line in changelog * Correct the description of issue in changelog
antonwolfy
added a commit
that referenced
this pull request
Sep 20, 2024
…2063) (#2068) * Add memory copy to device memory * Keep extra memcopy only for the result array * Add missing memory copy from host to device memory * Applied pre-commit formatting * Updated changelog * Add empty line in changelog * Correct the description of issue in changelog Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR resolves crash in
dpnp.chooseobserving in internal CI/CD flow on PVC machine with Linux OS.The issue was caused by missing dependency of temporary allocated device memory on a computing event. Thus the memory was released before the execution kernel completes work,
While allocation of temporary memory was implicit, because
DPNPC_ptr_adapterconstructor identified the input pointerchoices1as of unknown USM allocation type. And it was valid classification, since the pointer was allocated in host memory for holding a list of pointers on arrays in device memory.The change assumes to request explicit memory transfer for
choices1pointer from host to device memory and to add a dependency from the temporary allocated device memory on the event from the submitted kernel.