Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating tests - Part1 #2210

Merged
merged 8 commits into from
Dec 8, 2024
Merged

updating tests - Part1 #2210

merged 8 commits into from
Dec 8, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Dec 3, 2024

This is part 1 of a series of PRs in which the tests are refactored. In this PR, test_linalg.py, test_product.py, test_statistics.py, test_fft.py, test_mathematical.py and test_sort.py are updated.

Part 2 is #2227.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review December 4, 2024 00:57
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vtavana , thank you for the effort to refactor the tests. LGTM!

@vtavana vtavana merged commit 6dc39f9 into master Dec 8, 2024
47 of 48 checks passed
@vtavana vtavana deleted the update-tests-part-1 branch December 8, 2024 07:25
github-actions bot added a commit that referenced this pull request Dec 8, 2024
This is part 1 of a series of PRs in which the tests are refactored. In
this PR, `test_linalg.py`, `test_product.py`, `test_statistics.py`,
`test_fft.py`, and `test_sort.py` are updated. 6dc39f9
vtavana added a commit that referenced this pull request Dec 11, 2024
This is part 2 of a series of PRs in which the tests are refactored. In
this PR, `test_linalg.py`, `test_product.py`, `test_statistics.py`,
`test_fft.py`, and `test_sort.py` are updated.
Part 1 was #2210.

The main change is to use a common function
`generate_random_numpy_array` from `dpnp/tests/helper.py` for generating
input array for different tests.
github-actions bot added a commit that referenced this pull request Dec 11, 2024
This is part 2 of a series of PRs in which the tests are refactored. In
this PR, `test_linalg.py`, `test_product.py`, `test_statistics.py`,
`test_fft.py`, and `test_sort.py` are updated.
Part 1 was #2210.

The main change is to use a common function
`generate_random_numpy_array` from `dpnp/tests/helper.py` for generating
input array for different tests. d83ea3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants