Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in blas extensions during build on CUDA #2225

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Fix warnings in blas extensions during build on CUDA #2225

merged 4 commits into from
Dec 11, 2024

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR suggests using conditional logic in blas extensions (gemm, gemm_batch, gemv) to fix the warning about unused 'is_row_major' parameter during dpnp build on CUDA. The changes ensure that is_row_major parameter is only passed when the backend requires it.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev, LGTM

@vlad-perevezentsev vlad-perevezentsev merged commit c4997cc into master Dec 11, 2024
47 of 48 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the fix_gemm_warning_cuda branch December 11, 2024 15:13
github-actions bot added a commit that referenced this pull request Dec 11, 2024
@github-actions
Fix warnings in blas extensions during build on CUDA (#2225)
8a1b3a3 
This PR suggests using conditional logic in blas extensions **(gemm,
gemm_batch, gemv**) to fix the warning about `unused 'is_row_major'
parameter` during dpnp build on CUDA. The changes ensure that
`is_row_major` parameter is only passed when the backend requires it. c4997cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy