Bump SYCL compiler min version required #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev and
vtavana
as code owners
vlad-perevezentsev
approved these changes
Dec 13, 2024
github-actions bot
added a commit
that referenced
this pull request
Dec 13, 2024
DPC++ compiler released 2025.0.4 version where `__SYCL_COMPILER_VERSION` is defined to `20241205`. But the fixes from #2211 and for `sycl::ext::intel::math::cyl_bessel_i0(x)` support weren't mapped there. Thus the PR proposes to bump `__SYCL_COMPILER_REDUCTION_PROPERTIES_SUPPORT` and `__SYCL_COMPILER_BESSEL_I0_SUPPORT` defines up to `20241210` value to exclude DPC++ compiler 2025.0.4 version. cf2a106
vtavana
pushed a commit
that referenced
this pull request
Dec 13, 2024
DPC++ compiler released 2025.0.4 version where `__SYCL_COMPILER_VERSION` is defined to `20241205`. But the fixes from #2211 and for `sycl::ext::intel::math::cyl_bessel_i0(x)` support weren't mapped there. Thus the PR proposes to bump `__SYCL_COMPILER_REDUCTION_PROPERTIES_SUPPORT` and `__SYCL_COMPILER_BESSEL_I0_SUPPORT` defines up to `20241210` value to exclude DPC++ compiler 2025.0.4 version.
6 tasks
antonwolfy
added a commit
that referenced
this pull request
Dec 16, 2024
The PR proposes to resolve the issue observing in GitHub actions where `mamba search --info` results into `The following argument was not expected: --info` error. The error started to be reported since `mamba==2.0.5` release. As a workaround it is proposed to switch to `conda search --info` command which works properly. Note, #2231 is tuned here to consider available DPC++ version on Windows.
github-actions bot
added a commit
that referenced
this pull request
Dec 16, 2024
The PR proposes to resolve the issue observing in GitHub actions where `mamba search --info` results into `The following argument was not expected: --info` error. The error started to be reported since `mamba==2.0.5` release. As a workaround it is proposed to switch to `conda search --info` command which works properly. Note, #2231 is tuned here to consider available DPC++ version on Windows. 584f0cb
vtavana
pushed a commit
that referenced
this pull request
Dec 16, 2024
The PR proposes to resolve the issue observing in GitHub actions where `mamba search --info` results into `The following argument was not expected: --info` error. The error started to be reported since `mamba==2.0.5` release. As a workaround it is proposed to switch to `conda search --info` command which works properly. Note, #2231 is tuned here to consider available DPC++ version on Windows.
vtavana
pushed a commit
that referenced
this pull request
Dec 17, 2024
DPC++ compiler released 2025.0.4 version where `__SYCL_COMPILER_VERSION` is defined to `20241205`. But the fixes from #2211 and for `sycl::ext::intel::math::cyl_bessel_i0(x)` support weren't mapped there. Thus the PR proposes to bump `__SYCL_COMPILER_REDUCTION_PROPERTIES_SUPPORT` and `__SYCL_COMPILER_BESSEL_I0_SUPPORT` defines up to `20241210` value to exclude DPC++ compiler 2025.0.4 version.
vtavana
pushed a commit
that referenced
this pull request
Dec 17, 2024
The PR proposes to resolve the issue observing in GitHub actions where `mamba search --info` results into `The following argument was not expected: --info` error. The error started to be reported since `mamba==2.0.5` release. As a workaround it is proposed to switch to `conda search --info` command which works properly. Note, #2231 is tuned here to consider available DPC++ version on Windows.
vtavana
pushed a commit
that referenced
this pull request
Dec 17, 2024
DPC++ compiler released 2025.0.4 version where `__SYCL_COMPILER_VERSION` is defined to `20241205`. But the fixes from #2211 and for `sycl::ext::intel::math::cyl_bessel_i0(x)` support weren't mapped there. Thus the PR proposes to bump `__SYCL_COMPILER_REDUCTION_PROPERTIES_SUPPORT` and `__SYCL_COMPILER_BESSEL_I0_SUPPORT` defines up to `20241210` value to exclude DPC++ compiler 2025.0.4 version.
vtavana
pushed a commit
that referenced
this pull request
Dec 17, 2024
The PR proposes to resolve the issue observing in GitHub actions where `mamba search --info` results into `The following argument was not expected: --info` error. The error started to be reported since `mamba==2.0.5` release. As a workaround it is proposed to switch to `conda search --info` command which works properly. Note, #2231 is tuned here to consider available DPC++ version on Windows.
antonwolfy
added a commit
that referenced
this pull request
Dec 20, 2024
The PR proposes to resolve the issue observing in GitHub actions where `mamba search --info` results into `The following argument was not expected: --info` error. The error started to be reported since `mamba==2.0.5` release. As a workaround it is proposed to switch to `conda search --info` command which works properly. Note, #2231 is tuned here to consider available DPC++ version on Windows.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DPC++ compiler released 2025.0.4 version where
__SYCL_COMPILER_VERSIONis defined to20241205. But the fixes from #2211 and forsycl::ext::intel::math::cyl_bessel_i0(x)support weren't mapped there.Thus the PR proposes to bump
__SYCL_COMPILER_REDUCTION_PROPERTIES_SUPPORTand__SYCL_COMPILER_BESSEL_I0_SUPPORTdefines up to20241210value to exclude DPC++ compiler 2025.0.4 version.