Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nd-support to dpnp.trim_zeros #2241

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Dec 18, 2024

The PR extends dpnp.trim_zeros implement to align with changes introduced in NumPy 2.2.

It adds support for trimming nd-arrays while preserving the old behavior for 1-d input. The new parameter axis can specify a single dimension to be trimmed (reducing all other dimensions to the envelope of absolute values). By default (when None is specified), all dimensions are trimmed iteratively.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Dec 18, 2024
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2241/index.html

@coveralls
Copy link
Collaborator

coveralls commented Dec 18, 2024

Coverage Status

coverage: 65.095% (+0.02%) from 65.074%
when pulling 21be8f4 on nd-support-to-trim_zero
into cabc0d7 on master.

@antonwolfy antonwolfy marked this pull request as ready for review December 18, 2024 15:36
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants