This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
impl loc callable #501
Open
impl loc callable #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
densmirn
reviewed
Jan 15, 2020
| return new_series | ||
|
|
||
| return hpat_pandas_series_loc_callable_impl | ||
|
|
||
| raise TypingError('{} The index must be an Number, Slice, String, List, Array or a callable.\ |
There was a problem hiding this comment.
Looks like we need to remove the exception raising.
densmirn
reviewed
Jan 15, 2020
sdc/tests/test_series.py
Outdated
| @skip_sdc_jit('Not impl in old style') | ||
| def test_series_loc_callable(self): | ||
| def test_impl(S): | ||
| return S.loc[(lambda a: a)] |
There was a problem hiding this comment.
Do you exactly need round brackets around of lambda?
There was a problem hiding this comment.
Maybe to complicate lambda, e.g. a -> a ** 2?
densmirn
reviewed
Jan 15, 2020
sdc/tests/test_series.py
Outdated
| @skip_sdc_jit('Not impl in old style') | ||
| def test_series_loc_callable(self): | ||
| def test_impl(S): | ||
| return S.loc[(lambda a: a)] |
There was a problem hiding this comment.
Maybe to complicate lambda, e.g. a -> a ** 2?
| pd.testing.assert_series_equal(hpat_func(S), test_impl(S)) | ||
|
|
||
| @unittest.skip('Loc callable return float Series') | ||
| def test_series_loc_callable2(self): |
There was a problem hiding this comment.
What do you think about merging of test_series_loc_callable and test_series_loc_callable2?
There was a problem hiding this comment.
Because implementation has limit and always return float Series. In that case pandas return int Series, and we return float Series. I wrote about it in notes in loc.
Test skips with expected failure
densmirn
approved these changes
Jan 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.