Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even if cURL is already installed in the system CMake clones it and compiles it. #10087

Closed
AlejoDiaz49 opened this issue Dec 21, 2021 · 3 comments

Comments

@AlejoDiaz49
Copy link

Required Info
Operating System & Version Ubuntu 20.04
Kernel Version (Linux Only) 5.11.0-43
Platform PC x86_64
SDK Version 2.50.0

Issue Description

I was updating my system to a newer version of the library, and during the compilation, I noticed that Libcurl is now cloned and compiled.

I have Libcurl (OpenSSL) and also Libcurlpp installed in my system so I was wondering why during compilation it does not try to use it. I only found the file CMake/external_libcurl.cmake and it looks like it doesn't check at all.

Is this for a reason? Otherwise, it could make the first compilation faster and also occupy less space

Also just to make sure that I understood correctly cURL is used when CHECK_FOR_UPDATES is ON and it is for checking new SDK versions. Is it for something else?

Thanks in advanced :)

@MartyG-RealSense
Copy link
Collaborator

MartyG-RealSense commented Dec 21, 2021

Hi @AlejoDiaz49 I should emphasize in advance that this is a development-focused question, so my knowledge of this subject is limited. I will do my best to provide useful information though.

  • From SDK version 2.43.0 onwards, it looks as though a mechanism is introduced to ensure that the libcurl third-party is version 7.75 as a requirement.

#8463

  • It looks as though the link library targets ws2_32.lib crypt32.lib, ELSE it tries to find_package openSSL if it is not found.

  • There is a CMake build flag called DCHECK_FOR_UPDATES that can be set to Off. This is so that Mac users can disable it.

-DCHECK_FOR_UPDATES=OFF

#9732

  • The link below to the main CMakeLists.txt file highlights what is is performed in relation to realsense-viewer when CHECK_FOR_UPDATES is true.

https://github.com/IntelRealSense/librealsense/blob/master/tools/realsense-viewer/CMakeLists.txt#L235

@MartyG-RealSense
Copy link
Collaborator

Hi @AlejoDiaz49 Do you require further assistance with this case, please? Thanks!

@MartyG-RealSense
Copy link
Collaborator

Case closed due to no further comments received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants