Fix menu bar color changing logic #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting at least in Catalina, it's not the style for menu bar items to change color when clicked.
Starting at least in Big Sur, the menu bar may display icons in dark/highlighted mode even if the system theme is not in dark mode. This can occur when the menu bar is shown in fullscreen mode or depending on the desktop wallpaper.
|
I am actually using Ventura 13.0.1 on M1 and Caffeine 1.1.3, the icon is always black. Hope this fix solves it in the next update. |
I have the same issue. Will this be merged in the near future? |
Hi! Could you please merge and release the fix? :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old logic for determining whether to display in dark mode or not doesn't work any more as the color of the menu bar isn't connected to whether the system is in dark mode or not.
Additionally, it's not the style any more to highlight menu bar icons when clicked on. Doing so makes them hard to see.