Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#209); try scrapping acorns #210

Merged
merged 3 commits into from
Oct 10, 2023
Merged

feat(#209); try scrapping acorns #210

merged 3 commits into from
Oct 10, 2023

Conversation

StephanHCB
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING.md
  • I have made corresponding changes to the documentation
  • My changes generate no lint errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Only MIT licensed or MIT license compatible dependencies are used (e.g.: Apache2 or BSD)
  • The code contains no credentials, personalized data or company secrets

@StephanHCB StephanHCB force-pushed the testing_poc_noacorn branch from 6bc3b2e to f8ce742 Compare October 9, 2023 11:52
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 248 lines in your changes are missing coverage. Please review.

Comparison is base (3b25b41) 59.26% compared to head (529cdc4) 60.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   59.26%   60.65%   +1.39%     
==========================================
  Files          69       50      -19     
  Lines        5464     5162     -302     
==========================================
- Hits         3238     3131     -107     
+ Misses       1977     1813     -164     
+ Partials      249      218      -31     
Files Coverage Δ
internal/repository/config/plumbing.go 95.12% <100.00%> (+0.16%) ⬆️
internal/service/mapper/repository.go 60.12% <100.00%> (ø)
internal/service/mapper/service.go 63.48% <100.00%> (ø)
internal/service/updater/owners.go 68.88% <100.00%> (ø)
internal/service/updater/repositories.go 64.16% <100.00%> (ø)
internal/service/updater/services.go 62.22% <100.00%> (ø)
internal/service/owners/owners.go 82.95% <88.23%> (+0.36%) ⬆️
internal/service/repositories/repositories.go 84.64% <89.47%> (+0.20%) ⬆️
internal/service/services/services.go 81.88% <89.47%> (+0.37%) ⬆️
internal/web/controller/ownerctl/ownerctl.go 88.58% <80.00%> (-0.50%) ⬇️
... and 16 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StephanHCB StephanHCB force-pushed the testing_poc_noacorn branch from f8ce742 to 1245869 Compare October 9, 2023 12:34
@StephanHCB StephanHCB marked this pull request as ready for review October 10, 2023 15:16
@StephanHCB StephanHCB merged commit 46059b2 into main Oct 10, 2023
3 of 4 checks passed
@StephanHCB StephanHCB deleted the testing_poc_noacorn branch October 25, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant