-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export Target type from ouroboros-network, to be more convenient to users #448
Conversation
86b93cd
to
1bb2df1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think it was @Jimbo4350's idea with reexposing stuff. I'm leaving approval to him if this is the direction we want to follow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to discuss how we want to expose things on a module basis. Can you create an issue for this? We have strayed far from what was originally envisioned with the Cardano.Api
and Cardano.Api.Shelley
but I am partly to blame :).
@Jimbo4350> issue created: #449 |
…curences-5 Replace usages of assertFileOccurences (5/6)
This PR is stale because it has been open 45 days with no activity. |
I think this is fine. The alternative to this would be users traversing the |
1bb2df1
to
39b0177
Compare
Changelog
Context
Fixes #447
Fixes #449
How to trust this PR
User-facing API only
Checklist