Fix incorrect fees estimation when balancing transaction minting assets #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
changed the title
carbolymer
changed the title
carbolymer
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy,
smelc,
palas,
kevinhammond,
CarlosLopezDeLara and
disassembler
as code owners
carbolymer
force-pushed
the
mgalazyn/fix/invalid-fee-when-autobalancing-minting
branch
3 times, most recently
from
10c5809 to
fdc91b3
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
carbolymer
force-pushed
the
mgalazyn/fix/invalid-fee-when-autobalancing-minting
branch
7 times, most recently
from
a83f93b to
88aceab
Compare
carbolymer
force-pushed
the
mgalazyn/fix/invalid-fee-when-autobalancing-minting
branch
from
88aceab to
dc5d4cb
Compare
carbolymer
commented
Aug 29, 2024
| UnsignedTx unsignedTx0 <- | ||
| first TxBodyError | ||
| $ makeUnsignedTx | ||
| availableEra | ||
| $ obtainShimConstraints bEraOnwards | ||
| $ txbodycontent | ||
| { txOuts = | ||
| txOuts txbodycontent | ||
| ++ [TxOut changeaddr (lovelaceToTxOutValue sbe 0) TxOutDatumNone ReferenceScriptNone] | ||
| -- TODO: think about the size of the change output |
There was a problem hiding this comment.
@Jimbo4350 What does this TODO mean? This PR changes the TxOut to include all assets from TxIns and minted ones, so I guess this TODO is fixed?
There was a problem hiding this comment.
Duncan left that there and I can't remember why.
carbolymer
commented
Aug 29, 2024
| address | ||
| Nothing | ||
| -- the correct amount with manual balancing of assets | ||
| 335_729 === feeWithTxoutAsset |
There was a problem hiding this comment.
This PR does not change the value of the fee here.
Jimbo4350
approved these changes
Aug 29, 2024
| UnsignedTx unsignedTx0 <- | ||
| first TxBodyError | ||
| $ makeUnsignedTx | ||
| availableEra | ||
| $ obtainShimConstraints bEraOnwards | ||
| $ txbodycontent | ||
| { txOuts = | ||
| txOuts txbodycontent | ||
| ++ [TxOut changeaddr (lovelaceToTxOutValue sbe 0) TxOutDatumNone ReferenceScriptNone] | ||
| -- TODO: think about the size of the change output |
There was a problem hiding this comment.
Duncan left that there and I can't remember why.
| ++ [TxOut changeaddr (lovelaceToTxOutValue sbe 0) TxOutDatumNone ReferenceScriptNone] | ||
| -- TODO: think about the size of the change output | ||
| -- 1,2,4 or 8 bytes? | ||
| TxOut changeaddr (TxOutValueShelleyBased sbe change) TxOutDatumNone ReferenceScriptNone |
There was a problem hiding this comment.
I think we had an issue in the past where users were expecting the change output to be appended to the list of tx outs. We best not change it. There may be an issue about this floating around somewhere.
There was a problem hiding this comment.
That's just an intermediary txbodycontent for execution units calculation. I'll change the order.
carbolymer
force-pushed
the
mgalazyn/fix/invalid-fee-when-autobalancing-minting
branch
from
dc5d4cb to
7535526
Compare
carbolymer
deleted the
mgalazyn/fix/invalid-fee-when-autobalancing-minting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
This PR should be reviewed on commit-by-commit basis.
Deprecate valueFromList and valueToList. Add IsList Value- contains refactor commitFix fee estimation when autobalancing assetsimplement the test case and the fix for Incorrect script budget estimation when minting assets and autobalancing a transaction cardano-cli#614Checklist