-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor TxMintValue
#663
Refactor TxMintValue
#663
Conversation
ef2b00c
to
c2c740b
Compare
6e860f9
to
fefbe40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. One gripe regarding traverseScriptWitnesses
. Clean up and I'll have a final look before approving.
|
||
traverseScriptWitnesses | ||
:: [(a, Either (TxBodyErrorAutoBalance era) (ScriptWitness ctx era))] | ||
-> Either (TxBodyErrorAutoBalance era) [(a, ScriptWitness ctx era)] | ||
:: [(a, Either (TxBodyErrorAutoBalance era) b)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be "neater" Haskell but making this more generic doesn't really help the reader IMO. Also it's only instantiated to ScriptWitness ctx era
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not only instantiated to ScriptWitness ctx era
- in line 1629 it is used against
[ (Value, Either (TxBodyErrorAutoBalance era)
( AssetName
, Quantity
, BuildTxWith build (ScriptWitness WitCtxMint era)
)
]
So the previous function type won't work.
(Map PolicyId (ScriptWitness WitCtxMint era)) | ||
-> Map | ||
PolicyId | ||
[ ( AssetName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A 3-tuple is less than ideal but I can't think of what to call this instead.
5842e38
to
416a201
Compare
|
7953b50
to
6bcac77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
6bcac77
to
927cf0a
Compare
927cf0a
to
0f51874
Compare
Changelog
Context
Supersedes:
Fixes:
Maybe ScriptHash
fromPReferenceScript
#606Checklist