Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Show (Some a) and Eq (Some a). Add Show (Some Era) and Eq (Some Era). #665

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Oct 28, 2024

Changelog

- description: |
    `Remove `Show (Some a)` and `Eq (Some a)`. Add `Show (Some Era)` and `Eq (Some Era)`.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

A follow-up from: IntersectMBO/cardano-node#6017 (comment)

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/refactor/remove-some-instances branch from 409c1cd to b72fc8d Compare November 19, 2024 13:10
@carbolymer carbolymer changed the title Remove Show (Some a) and Eq (Some a). Add a newtype SomeSingletonType1 providing those instances using deriving via. Remove Show (Some a) and Eq (Some a). Add Show Some Era) and Eq (Some Era)`. Nov 19, 2024
@carbolymer carbolymer requested a review from Jimbo4350 November 19, 2024 13:16
@carbolymer carbolymer changed the title Remove Show (Some a) and Eq (Some a). Add Show Some Era) and Eq (Some Era)`. Remove Show (Some a) and Eq (Some a). Add Show (Some Era) and Eq (Some Era). Nov 19, 2024
@carbolymer carbolymer added this pull request to the merge queue Nov 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 19, 2024
@carbolymer carbolymer added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit fba6b41 Nov 19, 2024
32 checks passed
@carbolymer carbolymer deleted the mgalazyn/refactor/remove-some-instances branch November 19, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants