Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export GovActionIx from the ledger #688

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 22, 2024

Changelog

- description: |
    Export GovActionIx from the ledger
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Required for the CLI part of #684

How to trust this PR

It's only an export

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc
Copy link
Contributor Author

smelc commented Nov 22, 2024

cc @CarlosLopezDeLara, since is the symbol we saw during our pairing session 👋

Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem controversial 🙂

@smelc smelc enabled auto-merge November 25, 2024 09:55
@smelc smelc force-pushed the smelc/cl/expose-ledger-govactionix branch from 07b95aa to 7d7dba1 Compare November 26, 2024 20:24
@smelc smelc added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 26, 2024
@smelc smelc added this pull request to the merge queue Nov 26, 2024
Merged via the queue into master with commit 4f81141 Nov 26, 2024
29 checks passed
@smelc smelc deleted the smelc/cl/expose-ledger-govactionix branch November 26, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants