Don't export coerceKeyRole, export RewardAccount

[smelc]

Changelog

- description: |
    Don't export the ledger's `coerceKeyRole` function anymore, export RewardAccount
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

• Required for Augment of query spo-stake-distribution to include the DRep delegation choices of the Pool's rewards accounts cardano-cli#990
• This is the datatype RewardAccount that is being exported
• The export of coerceKeyRole is no longer necessary for solving [FEATURE] - Update cardano-cli conway query spo-stake-distribution cardano-cli#911, which is good; because @Jimbo4350 had concerned about it (on Slack). I must say I readied Export HasKeyRole's coerceKeyRole function #699 too fast.

Not marking this one as breaking, because it actually reverts #699. Since there was no release since 699, overall it's not going to be a breaking change.

Edit: There was 10.4.0.0 release, so marking it as breaking

How to trust this PR

The new export only concerns a data structure, nothing controversial

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• Self-reviewed the diff

[palas]

Looks good, but it does seem breaking. It would need to be noted in the changelog

[smelc]

@Jimbo4350> confirmed with lehins that the only valid use of coercing key roles is for the Witness role. But even then, Alexei strongly supports not exporting it:

That is the whole point of the key roles. It should not be needed and usually when people try to do it, that means that they are doing something wrong.

In other words by exposing such casting we would promote people making mistakes

[CarlosLopezDeLara]

There was a 10.4.0.0 release between #699 and #708 therefore this is a breaking change.

cardano-api on  master [$] via λ 9.10.1 
❯ git log --oneline
a429ac21a (HEAD -> master, origin/master, origin/HEAD) Merge pull request #708 from IntersectMBO/smelc/exports-for-augmented-spo-stake-distribution
359017665 Expose the ledger's RewardAccount
cfc8ceac8 Revert "Export HasKeyRole's coerceKeyRole function"
8a91df50c Merge pull request #706 from locallycompact/lc/mint-modifiers
1d627a186 Add modifier functions for modifiable fields in TxBodyContent up to Babbage
8fc8660cb Add TxMintValue modifier functions
76fba1ca2 Merge pull request #704 from locallycompact/lc/extra-modifier-functions
1307d2af0 Add modifier functions for TxInsCollateral, TxInsReference, TxExtraKeyWits to Cardano.Api.Tx.Body
d6a956f91 Merge pull request #700 from IntersectMBO/release/cardano-api-10.4.0.0 <----RELEASE HERE
c21fad9c4 (tag: cardano-api-10.4.0.0) Release 10.4.0.0
6a42210d8 Merge pull request #684 from IntersectMBO/cl/queryProposals
b2c04da81 Implement "query proposals"
4396ad1fa Merge pull request #699 from IntersectMBO/smelc/additional-exports <--- 699 HERE