-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make --fee
mandatory in transaction build-raw
#768
Make --fee
mandatory in transaction build-raw
#768
Conversation
@@ -636,7 +636,7 @@ constructTxBodyContent | |||
-- ^ Withdrawals | |||
-> [Hash PaymentKey] | |||
-- ^ Required signers | |||
-> Maybe L.Coin | |||
-> L.Coin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure about this bit. I guess it makes sense to say in the function signature, that the fee is required and let users specify 0 if needed.
@@ -175,7 +176,7 @@ runLegacyTransactionBuildRawCmd | |||
runTransactionBuildRawCmd | |||
( Cmd.TransactionBuildRawCmdArgs | |||
sbe mScriptValidity txins readOnlyRefIns txinsc mReturnColl | |||
mTotColl reqSigners txouts mValue mLowBound upperBound fee certs wdrls | |||
mTotColl reqSigners txouts mValue mLowBound upperBound (fromMaybe 0 fee) certs wdrls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand, in Byron the fee is still optional?
…tory-in-transaction-build-raw Make `--fee` mandatory in `transaction build-raw`
Changelog
Context
Seems that fees should be mandatory for eras >= Shelley, but the CLI interface wasn't saying so and was defaulting to 0.
Checklist