transaction-build and build-estimate: include current treasury value only if a donation is being done #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nation presence Now transaction build-estimate as well as transaction build-raw needs to be adapted
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
1212
to
1216
| pCurrentTreasuryValueAndDonation sbe = | ||
| caseShelleyToBabbageOrConwayEraOnwards | ||
| (const $ pure Nothing) | ||
| (const $ optional $ TxCurrentTreasuryValue <$> coinParser) | ||
| where | ||
| coinParser :: Parser L.Coin = | ||
| Opt.option (readerFromParsecParser parseLovelace) $ mconcat | ||
| [ Opt.long "current-treasury-value" | ||
| , Opt.metavar "LOVELACE" | ||
| , Opt.help "The current treasury value." | ||
| ] | ||
| (const $ optional $ ((,) <$> pCurrentTreasuryValue' <*> pTreasuryDonation')) | ||
| sbe |
Check warning
Code scanning / HLint
Eta reduce Warning
CarlosLopezDeLara
requested review from
Jimbo4350,
newhoggy,
carbolymer,
palas,
kevinhammond and
disassembler
as code owners
Jimbo4350
reviewed
Jul 8, 2024
| let currentTreasuryValueAndDonation = | ||
| case (treasuryDonation, unFeatured <$> featuredCurrentTreasuryValueM) of | ||
| (Nothing, _) -> Nothing -- We shouldn't specify the treasury value when no donation is being done | ||
| (Just _td, Nothing) -> undefined -- TODO: Current treasury value couldn't be obtained but is required: we should fail suggesting that the node's version is too old |
Jimbo4350
force-pushed
the
smelc/tx-build-no-donation-then-no-current-treasury-value
branch
from
7535c58 to
cdc2262
Compare
Jimbo4350
approved these changes
Jul 8, 2024
Jimbo4350
force-pushed
the
smelc/tx-build-no-donation-then-no-current-treasury-value
branch
from
cdc2262 to
66ddd93
Compare
Jimbo4350
deleted the
smelc/tx-build-no-donation-then-no-current-treasury-value
branch
smelc
commented
Jul 10, 2024
| @@ -255,7 +261,7 @@ runTransactionBuildEstimateCmd | |||
| :: () | |||
| => Cmd.TransactionBuildEstimateCmdArgs era | |||
| -> ExceptT TxCmdError IO () | |||
| runTransactionBuildEstimateCmd | |||
| runTransactionBuildEstimateCmd -- TODO change type | |||
There was a problem hiding this comment.
This is a leftover TODO. It can be removed. cc @CarlosLopezDeLara
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Fixes #825
How to trust this PR
Checklist