Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix treasury withdrawal. #877

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fix treasury withdrawal. #877

merged 2 commits into from
Aug 28, 2024

Conversation

CarlosLopezDeLara
Copy link
Contributor

@CarlosLopezDeLara CarlosLopezDeLara commented Aug 28, 2024

Changelog

- description: |
    Make funds receiving address and amount mandatory. 
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Resolves #876

How to trust this PR

Now, creating the proposal fails if there is no receiving address supplied.

cardano-cli conway governance action create-treasury-withdrawal --testnet \
--governance-action-deposit 100000000000 \
--deposit-return-stake-script-file keys/stake-multisig.json \
--anchor-url https://tinyurl.com/3wrwb2as \
--anchor-data-hash 52e69500a92d80f2126c836a4903dc582006709f004cf7a28ed648f732dff8d2 \
--out-file transactions/treasury-no-receive-address.action

Missing: (
    ( --funds-receiving-stake-verification-key STRING
    | --funds-receiving-stake-verification-key-file FILE
    | --funds-receiving-stake-key-hash HASH
    )
    --transfer LOVELACE)

Usage: cardano-cli conway governance action create-treasury-withdrawal

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • [] New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@CarlosLopezDeLara CarlosLopezDeLara marked this pull request as ready for review August 28, 2024 14:35
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 💯

@CarlosLopezDeLara CarlosLopezDeLara added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 9e2dd2c Aug 28, 2024
26 checks passed
@CarlosLopezDeLara CarlosLopezDeLara deleted the cl/treasurywithdrawal branch August 28, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants