Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release cardano-cli-9.4.0.0 #885

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Release cardano-cli-9.4.0.0 #885

merged 1 commit into from
Sep 6, 2024

Conversation

Jimbo4350
Copy link
Contributor

Changelog

- description: |
    Release cardano-cli-9.4.0.0
# uncomment types applicable to the change:
  type:
  - release        # related to a new release preparation

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the release/cardano-cli-9.4.0.0 branch from 6e26329 to 27f3b98 Compare September 5, 2024 21:07
carbolymer
carbolymer requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release PR shouldn't contain other changes than version bump and changelog update.

@Jimbo4350
Copy link
Contributor Author

Release PR shouldn't contain other changes than version bump and changelog update.

I know. I was waiting for #853 to be merged.

@Jimbo4350 Jimbo4350 requested a review from carbolymer September 6, 2024 12:40
@Jimbo4350 Jimbo4350 force-pushed the release/cardano-cli-9.4.0.0 branch from 27f3b98 to 2631b3e Compare September 6, 2024 12:41
@Jimbo4350 Jimbo4350 enabled auto-merge September 6, 2024 12:46
@Jimbo4350 Jimbo4350 disabled auto-merge September 6, 2024 12:46
@Jimbo4350 Jimbo4350 force-pushed the release/cardano-cli-9.4.0.0 branch from 2631b3e to d1b1580 Compare September 6, 2024 12:49
@Jimbo4350 Jimbo4350 enabled auto-merge September 6, 2024 12:49
@Jimbo4350 Jimbo4350 force-pushed the release/cardano-cli-9.4.0.0 branch 3 times, most recently from b6a013f to 422fd2e Compare September 6, 2024 13:15
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Sep 6, 2024
@Jimbo4350 Jimbo4350 removed this pull request from the merge queue due to a manual request Sep 6, 2024
@Jimbo4350 Jimbo4350 force-pushed the release/cardano-cli-9.4.0.0 branch from 422fd2e to 6777e13 Compare September 6, 2024 14:20
@Jimbo4350 Jimbo4350 enabled auto-merge September 6, 2024 14:20
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit e64120d Sep 6, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@smelc smelc Awaiting requested review from smelc

@palas palas Awaiting requested review from palas

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jimbo4350 @carbolymer