-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for certificates to register and delegate stake simultaneously #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosLopezDeLara
requested review from
Jimbo4350,
newhoggy,
carbolymer,
smelc,
palas,
kevinhammond and
disassembler
as code owners
September 30, 2024 18:43
CarlosLopezDeLara
force-pushed
the
cl/stakereganddeleg
branch
2 times, most recently
from
September 30, 2024 19:14
fbf6e03
to
465a054
Compare
This certificate registers a stake address and delegates to a pool simultaneously: From CDDL: stake_reg_deleg_cert = (11, stake_credential, pool_keyhash, coin) add golden test for `stake_reg_deleg_cert` add golden test for `stake_reg_deleg_cert` update golden files Update StakeAddress.hs pretiffy register and delegate to a pool
CarlosLopezDeLara
force-pushed
the
cl/stakereganddeleg
branch
from
September 30, 2024 19:48
b3b610b
to
8e8c070
Compare
CarlosLopezDeLara
force-pushed
the
cl/stakereganddeleg
branch
from
September 30, 2024 20:39
63af950
to
0ca3935
Compare
smelc
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 👏
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/StakeAddress.hs
Show resolved
Hide resolved
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/StakeAddress.hs
Show resolved
Hide resolved
Co-authored-by: Clément Hurlin <smelc@users.noreply.github.com>
…keAddress.hs Co-authored-by: Clément Hurlin <smelc@users.noreply.github.com>
…keAddress.hs Co-authored-by: Clément Hurlin <smelc@users.noreply.github.com>
CarlosLopezDeLara
removed this pull request from the merge queue due to a manual request
Oct 1, 2024
CarlosLopezDeLara
changed the title
Cl/stakereganddeleg
Add support for certificates to register and delegate stake simultaneously
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Resolves #909
The Conway CDDL includes this certificate. It was not a priority during the initial Conway implementation because one can achieve the same result with a combination of the other certificates.
How to trust this PR
which matches the expected certificate from the cddl:
The same with:
and for
Checklist