Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSON schema checking functionality for DRep and Gov action metadata #995

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add JSON schema checking functionality for DRep and Gov action metadata #995

wants to merge 9 commits into from
+786 −318

Conversation

palas
Copy link
Contributor

@palas palas commented Dec 20, 2024 •
edited
Loading

Changelog

- description: |
    Added schema checking functionality for DRep registration, DRep update, and GovAction metadata, based on CIP-0100, CIP-0108, and CIP-0119. Updated tests. Refactored test data for improved code clarity.
  type:
  - feature
  - refactoring
  - test

Context

The objective is addressing this issue: #906

This PR is based on cardano-api PR #713, which provides the required functionality, and this PR should not be merged until the cardano-api PR gets released and the source repo stanza is removed.

How to trust this PR

I think, checking the changes to the tests here is key, and the main part. The actual functionality is in cardano-api PR #713 (I would check that one together with this). The latest commit should also be pure refactoring.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added enhancement New feature or request DO NOT MERGE next-update Needs a dependency to be updated to be merged labels Dec 20, 2024
@palas palas self-assigned this Dec 20, 2024
@palas palas linked an issue Dec 20, 2024 that may be closed by this pull request
Governance metadata is not validated #906
Open
@palas palas changed the title Gov action schema checking Add JSON schema checking functionality for DRep and Gov action metadata Dec 20, 2024
@palas palas force-pushed the gov-action-schema-checking branch from 0bba7fc to 92bd7ee Compare December 20, 2024 15:17
@palas palas force-pushed the gov-action-schema-checking branch from 92bd7ee to 18fc533 Compare December 20, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer is a code owner

@smelc smelc Awaiting requested review from smelc smelc is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@palas palas

Labels
enhancement New feature or request next-update Needs a dependency to be updated to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Governance metadata is not validated
1 participant
@palas