Generalise block to (theoretically) support Byron and Shelley #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This insulates the DB actions from the type level abstraction over the different kinds of blocks. Below this level, the DB deals with concrete block types so this abstraction removal needs to be done at a layer above. Specifically, we add Byron and Shelley specific constructors for each of the apply block and rollback actions. When Gougan comes, we will need another pair of constructors.
This still only supports Byron, but Byron is specified at the very top level using 'mkByronConsensusConfig'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still only supports Byron, but Byron is specified at the very top level using 'mkByronConsensusConfig'.
Tested locally on my mainnet and testnet nodes.