Fix active_epoch_no of PoolUpdates #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kderme
force-pushed
the
kderme/fix-active_epoch_no
branch
2 times, most recently
from
16d113b
to
df719d0
Compare
kderme
force-pushed
the
kderme/fix-active_epoch_no
branch
2 times, most recently
from
10dac50
to
915b253
Compare
erikd
reviewed
May 18, 2021
| @@ -296,14 +297,23 @@ insertPoolRegister tracer network (EpochNo epoch) txId idx params = do | |||
| ] | |||
|
|
|||
| poolHashId <- insertPoolHash (Shelley._poolId params) | |||
|
|
|||
| let wasPoolRegistered = Set.member (Shelley._poolId params) $ getPoolParams $ lssOldState lStateSnap | |||
There was a problem hiding this comment.
I think this is big enough to be pulled out into a separate function, even if its in a where clause.
erikd
reviewed
May 20, 2021
| @@ -86,6 +88,7 @@ import Ouroboros.Network.Block (HeaderHash, Point (..)) | |||
| import qualified Ouroboros.Network.Point as Point | |||
|
|
|||
| import qualified Shelley.Spec.Ledger.BaseTypes as Shelley | |||
| import Shelley.Spec.Ledger.Keys | |||
There was a problem hiding this comment.
All imports from outside this repo should be qualified or explicit.
This makes it easier to figure out where a symbol comes from
kderme
force-pushed
the
kderme/fix-active_epoch_no
branch
from
915b253
to
e2d1afa
Compare
erikd
force-pushed
the
kderme/fix-active_epoch_no
branch
4 times, most recently
from
62c0731
to
2b8026d
Compare
Previously, the value inserted in the activeEpochNo field did not match the actual behaviour of the ledger rules. The epoch where the update becomes active is the current epoch plus two or three. * If the pool is found in `_pParams` field of `PState` before the current block its `+3` (retirements in the current block are irrelevant). * If it's not found, but there is already another `PoolReg` in the current block it's `+3` (we can check this from the db). * Otherwize its `+2`. Closes: #610
erikd
force-pushed
the
kderme/fix-active_epoch_no
branch
from
2b8026d
to
c226c4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.