Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement genesisHash #1558

Closed
wants to merge 1 commit into from
Closed

Implement genesisHash #1558

wants to merge 1 commit into from

Conversation

mrBliss
Copy link
Contributor

@mrBliss mrBliss commented Jun 16, 2020

No description provided.

@mrBliss mrBliss requested review from JaredCorduan and nc6 June 16, 2020 13:25
@mrBliss mrBliss requested a review from uroboros as a code owner June 16, 2020 13:25
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrBliss
Copy link
Contributor Author

mrBliss commented Jun 17, 2020

@dcoutts Are you okay with this?

@mrBliss
Copy link
Contributor Author

mrBliss commented Jun 18, 2020

@dcoutts decided to use the hash of the genesis JSON file instead. That hash can be computed without needing to run the right version of the code from this repo (e.g., in 10 years, it will still be easy to compute the hash, maybe when this repo is long gone 👴). It is also much easier for users to compute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants