handle unregistered reward accounts in applyRUpd #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redxaxder
approved these changes
Jun 30, 2020
nc6
reviewed
Jul 1, 2020
| \begin{itemize} | ||
| \item Rewards for accounts that are still registered are added to the reward mappings. | ||
| \item The sum of the unregistered rewards are added to the reserves. | ||
| % TODO - We may want to add these to the treasury instead, to be consistent with our other choices. |
There was a problem hiding this comment.
Yeah. I added them to the reserves in order to have the same outcome as if they had not been registered in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes adds the changes from #1598 to the spec.