introduce flexible cost model decoding #3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
force-pushed
the
jc/graceful-costmodel
branch
5 times, most recently
from
4534985 to
5ff2e3e
Compare
teodanciu
reviewed
Feb 8, 2023
teodanciu
reviewed
Feb 8, 2023
teodanciu
reviewed
Feb 8, 2023
teodanciu
approved these changes
Feb 8, 2023
lehins
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
This is really awesome!!!
It is only after going through this PR that I was able to convince myself that this is a really good approach to deal with forward compatibility of CostModels. I could not think of anything that could mess it up. Very nice!
I have a few suggestions, but nothing that would block the PR.
eras/alonzo/test-suite/src/Test/Cardano/Ledger/Alonzo/Serialisation/Generators.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/testlib/Test/Cardano/Ledger/Binary/RoundTrip.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/testlib/Test/Cardano/Ledger/Binary/RoundTrip.hs
Outdated
Show resolved
Hide resolved
JaredCorduan
force-pushed
the
jc/graceful-costmodel
branch
from
0152368 to
de24b06
Compare
Starting in version 9, 'CostModels' can now be deserialized from any map from Word8 values to lists of integers. Only valid cost models are actual converted to cost models. resolves #2902
JaredCorduan
force-pushed
the
jc/graceful-costmodel
branch
from
de24b06 to
215d398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting in version 9,
CostModelscan now be deserialized from any map ofWord8values to lists of integers. Only valid cost models are actually converted to evaluation contexts that can be used. Errors and unrecognized language versions are stored in theCostModelstype so that:resolves #2902
Checklist
fourmolu(which can be run withscripts/fourmolize.sh