Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi asset and plutus debug fixes #3357

Merged
merged 8 commits into from
Mar 27, 2023
Merged

Multi asset and plutus debug fixes #3357

merged 8 commits into from
Mar 27, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Mar 27, 2023

Description

This PR adds fixes for two bugs:

  • Translation of mint field into the plutus execution context
  • Serialization/deserilization of PlutusDebug

Few minor extra things:

  • Renaming cmMap -> smValues
  • Improve error reporting with the help of FailT.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the CHANGELOG.md for affected package
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

JaredCorduan
JaredCorduan approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JaredCorduan
Copy link
Contributor

LEBTMN (looks even better to me now!)

@lehins lehins force-pushed the lehins/multi-asset-and-plutus-debug-fixes branch from 004a3cd to d2df678 Compare March 27, 2023 20:26
@lehins lehins enabled auto-merge March 27, 2023 22:40
@lehins lehins merged commit 259bebb into master Mar 27, 2023
@iohk-bors iohk-bors bot deleted the lehins/multi-asset-and-plutus-debug-fixes branch March 27, 2023 23:17
@lehins lehins mentioned this pull request Jul 21, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lehins @JaredCorduan