Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use motionNoConfidence drep thresholds to ratify NoConfidence #4516

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Jul 30, 2024

Description

If a stake credential delegates to a pre-defined DRep (abstain or no confidence), their stake is accounted for in ratification

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu marked this pull request as ready for review July 30, 2024 18:05
@teodanciu teodanciu force-pushed the td/default-dreps-test branch from 75f46cb to 1dcce4c Compare July 30, 2024 19:04
Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teodanciu teodanciu force-pushed the td/default-dreps-test branch from 1dcce4c to 1b07a6a Compare July 31, 2024 13:06
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thank you

@lehins lehins enabled auto-merge July 31, 2024 17:34
@lehins lehins merged commit 079bd13 into master Jul 31, 2024
126 checks passed
@lehins lehins deleted the td/default-dreps-test branch July 31, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants