Added method to compute over-the-wire CBOR encoded transaction size #4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocodile-dentist
force-pushed
the
mwojtowicz/tx-wire-size
branch
3 times, most recently
from
9b7fe28
to
5268608
Compare
crocodile-dentist
force-pushed
the
mwojtowicz/tx-wire-size
branch
from
5268608
to
2195d2b
Compare
lehins
requested changes
Aug 2, 2024
crocodile-dentist
force-pushed
the
mwojtowicz/tx-wire-size
branch
7 times, most recently
from
fd31bc2
to
163c89b
Compare
lehins
force-pushed
the
mwojtowicz/tx-wire-size
branch
from
163c89b
to
ae9d4fc
Compare
lehins
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Looks great. Thank you. Couple of minor issues with changelogs. In case you are curious to learn our release and versioning process for the future you can find it here: https://github.com/IntersectMBO/cardano-ledger/blob/master/RELEASING.md
crocodile-dentist
force-pushed
the
mwojtowicz/tx-wire-size
branch
from
d4b3093
to
2ed3faa
Compare
lehins
approved these changes
Aug 6, 2024
crocodile-dentist
force-pushed
the
mwojtowicz/tx-wire-size
branch
2 times, most recently
from
54ec1d0
to
5a20bc3
Compare
crocodile-dentist
force-pushed
the
mwojtowicz/tx-wire-size
branch
from
5a20bc3
to
d1b8e6c
Compare
This was referenced Aug 9, 2024
crocodile-dentist
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Sep 23, 2024
# Description This change introduces a new method wireSizeTx for the LedgerSupportsMempool class. It provides actual CBOR encoded transaction size as it is when transmitted over the network, which the difffusion layer could exploit. Also note that: - New code should be properly tested (even if it does not add new features). - The fix for a regression should include a test that reproduces said regression. IntersectMBO/cardano-ledger#4521 IntersectMBO/ouroboros-network#4926
crocodile-dentist
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Sep 24, 2024
# Description This change introduces a new method wireSizeTx for the LedgerSupportsMempool class. It provides actual CBOR encoded transaction size as it is when transmitted over the network, which the difffusion layer could exploit. Also note that: - New code should be properly tested (even if it does not add new features). - The fix for a regression should include a test that reproduces said regression. IntersectMBO/cardano-ledger#4521 IntersectMBO/ouroboros-network#4926
crocodile-dentist
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Sep 24, 2024
# Description This change introduces a new method wireSizeTx for the LedgerSupportsMempool class. It provides actual CBOR encoded transaction size as it is when transmitted over the network, which the difffusion layer could exploit. Also note that: - New code should be properly tested (even if it does not add new features). - The fix for a regression should include a test that reproduces said regression. IntersectMBO/cardano-ledger#4521 IntersectMBO/ouroboros-network#4926
crocodile-dentist
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Sep 24, 2024
# Description This change introduces a new method wireSizeTx for the LedgerSupportsMempool class. It provides actual CBOR encoded transaction size as it is when transmitted over the network, which the difffusion layer could exploit. Also note that: - New code should be properly tested (even if it does not add new features). - The fix for a regression should include a test that reproduces said regression. IntersectMBO/cardano-ledger#4521 IntersectMBO/ouroboros-network#4926
crocodile-dentist
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Sep 24, 2024
# Description This change introduces a new method wireSizeTx for the LedgerSupportsMempool class. It provides actual CBOR encoded transaction size as it is when transmitted over the network, which the difffusion layer could exploit. Also note that: - New code should be properly tested (even if it does not add new features). - The fix for a regression should include a test that reproduces said regression. IntersectMBO/cardano-ledger#4521 IntersectMBO/ouroboros-network#4926
crocodile-dentist
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Sep 24, 2024
# Description This change introduces a new method wireSizeTx for the LedgerSupportsMempool class. It provides actual CBOR encoded transaction size as it is when transmitted over the network, which the difffusion layer could exploit. Also note that: - New code should be properly tested (even if it does not add new features). - The fix for a regression should include a test that reproduces said regression. IntersectMBO/cardano-ledger#4521 IntersectMBO/ouroboros-network#4926
crocodile-dentist
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Sep 24, 2024
# Description This change introduces a new method wireSizeTx for the LedgerSupportsMempool class. It provides actual CBOR encoded transaction size as it is when transmitted over the network, which the difffusion layer could exploit. Also note that: - New code should be properly tested (even if it does not add new features). - The fix for a regression should include a test that reproduces said regression. IntersectMBO/cardano-ledger#4521 IntersectMBO/ouroboros-network#4926
crocodile-dentist
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Sep 24, 2024
# Description This change introduces a new method wireSizeTx for the LedgerSupportsMempool class. It provides actual CBOR encoded transaction size as it is when transmitted over the network, which the difffusion layer could exploit. Also note that: - New code should be properly tested (even if it does not add new features). - The fix for a regression should include a test that reproduces said regression. IntersectMBO/cardano-ledger#4521 IntersectMBO/ouroboros-network#4926
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A method for computing the true size of cbor encoded transactions is proposed which is useful and convenient for the upcoming changes to the diffusion layer.
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)