Stop reporting invalid refund when stake credential is not registered #4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
reviewed
Sep 9, 2024
teodanciu
reviewed
Sep 9, 2024
teodanciu
approved these changes
Sep 9, 2024
lehins
force-pushed
the
lehins/cleanup-deleg-rule
branch
from
17eee8e to
5429379
Compare
It has been noticed that currently we report invalid refunds, even the stake credential is not registered. This makes little sense, so this commit changes this behavior.
* Which allows is to avoid passing redundant arguments * Switch to pointfree style and avoid using same name fo rthe umap that is being modified
lehins
force-pushed
the
lehins/cleanup-deleg-rule
branch
from
5429379 to
50c9329
Compare
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@teodanciu pointed out to me today that we report an invalid refund
IncorrectDepositDELEGpredicate failure whenever stake credential is not registered. This is at the very least confusing, so this PR fixes this.Besides this fix this PR also improves performance:
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)