Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Conway implementation of RegTxCert and UnRegTxCert #4627

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

teodanciu
Copy link
Contributor

Description

Fixes the bug that causes the deposit in RegTxCert and UnRegTxCert to be omitted during translation in Conway.
Keeps the incorrect behaviour in translation for version 9.

Closes #4571

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu force-pushed the td/fix-reg-txcert-pattern branch 2 times, most recently from 6289cc0 to 526310d Compare September 12, 2024 20:55
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Just a few minor suggestions about bounds and such.

eras/babbage/impl/cardano-ledger-babbage.cabal Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/TxInfo.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-api/cardano-ledger-api.cabal Outdated Show resolved Hide resolved
in order to make it available to `toPlutusTxCert`
keeping the manifestation of the problem for protocol 9
@teodanciu teodanciu force-pushed the td/fix-reg-txcert-pattern branch from 526310d to 6ba4eaa Compare September 13, 2024 10:40
@teodanciu teodanciu force-pushed the td/fix-reg-txcert-pattern branch from 6ba4eaa to 85aee1a Compare September 13, 2024 12:21
@teodanciu teodanciu enabled auto-merge September 13, 2024 12:22
@teodanciu teodanciu merged commit 492d54c into master Sep 13, 2024
159 of 160 checks passed
@teodanciu teodanciu deleted the td/fix-reg-txcert-pattern branch September 13, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation of Stake Credential [Un]Registration with deposit to PlutusV3
2 participants