Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRep undelegation fix #4773

Merged
merged 4 commits into from
Nov 25, 2024
Merged

DRep undelegation fix #4773

merged 4 commits into from
Nov 25, 2024

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Nov 25, 2024 •
edited
Loading

Description

This PR fixes #4772

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins
Add access to other parts of Ledger to the debug repl envirnment
3f141a7
@lehins
Add a test case that can reproduce a bug with DRep delegations
273f3a8
@lehins
Fix a bug where DRep UnDelegation update is erased. Fixes #4772
c3059b0 
This is how it was suppose to be implemented to begin with, however this
fix no longer can be applied without a hradfork, so the follow up commit
will take care of that.
@lehins lehins requested a review from a team as a code owner November 25, 2024 18:42
@lehins lehins requested a review from neilmayhew November 25, 2024 18:42
@lehins
Make sure that the fix for #4772 is done safely
33a61fe 
We can no longer fix this issue without a hardfork. The danger of fixing
it without a hardfork would be that discrepencies in the ledger state
could lead to different nodes having different DRep delegations when we
out of the bootstrap, if such bug to be manifested on mainnet.

This commit ensures that the fix is applied during the hardfork out of
the bootstrap phase.
@lehins lehins force-pushed the lehins/drep-undelegation branch from 3a56835 to 33a61fe Compare November 25, 2024 19:59
@lehins lehins mentioned this pull request Nov 25, 2024
Closed
neilmayhew
neilmayhew approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@neilmayhew neilmayhew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice use of TDD :-)

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/HardFork.hs Show resolved Hide resolved
@lehins lehins merged commit 33e90ea into master Nov 25, 2024
154 checks passed
@lehins lehins deleted the lehins/drep-undelegation branch November 25, 2024 22:37
Crypto2099
Crypto2099 reviewed Nov 26, 2024
View reviewed changes
Copy link

@Crypto2099 Crypto2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crypto2099 Crypto2099 Crypto2099 left review comments

@neilmayhew neilmayhew neilmayhew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected removal of DRep delegation leading to an issue with withdrawal
3 participants
@lehins @neilmayhew @Crypto2099