Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haskell/merge/simple utxo delegation #9

Merged
merged 4 commits into from
Oct 16, 2018

Conversation

mgudemann
Copy link
Contributor

This merges the current delegation code into the simple UTxO Haskell model.

This required some refactoring and some things are only made type correct, e.g. AddrTxin in the hspec tests.

First step, merge data-structures from delegation into simple UTxO model. Make
UTxO model compile and tests pass.
Refactor `Coin` into its own module to prevent cyclic dependencies.
Adapt types in `LedgerState`.
This replaces the UTF operators for domain restriction and exclusion and for
UTxO union via ASCII approximations and the named function `union`.

I think it is much easier to get an editor to represent those in a nicer way
than it is to enter them via their UTF code.
@mgudemann mgudemann self-assigned this Oct 15, 2018
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgudemann mgudemann merged commit 7699681 into master Oct 16, 2018
@mgudemann mgudemann deleted the haskell/merge/simple_utxo_delegation branch October 16, 2018 05:57
JaredCorduan pushed a commit that referenced this pull request Feb 12, 2019
* Organise 'Ledger.Abstract' module.

* Create simple and witnessed ledgers.

The composition here is not especially nice - I suspect I am
pushing at the boundaries of what backpack can nicely do. But at least
for the moment I couldn't see a nicer way. Suggestions welcome!

* Fix 'InsufficientWitnesses' predicate.
kevinhammond added a commit that referenced this pull request Oct 28, 2019
# This is the 1st commit message:
Merge branch 'spec/incentives-kh' of https://github.com/input-output-hk/cardano-ledger-specs into spec/incentives-kh

# This is the commit message #2:

overcoming fake make error

Signed-off-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com>

# This is the commit message #3:

overcoming fake make error

Signed-off-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com>

# This is the commit message #4:

overcoming fake make error

Signed-off-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com>

# This is the commit message #5:

overcoming fake make error

Signed-off-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com>

# This is the commit message #6:

overcoming fake make error

Signed-off-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com>

# This is the commit message #7:

fix user.email

Signed-off-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com>

# This is the commit message #8:

overcoming fake make error

Signed-off-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com>

# This is the commit message #9:

overcoming fake make error

Signed-off-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com>
nc6 added a commit that referenced this pull request May 19, 2020
* Organise 'Ledger.Abstract' module.

* Create simple and witnessed ledgers.

The composition here is not especially nice - I suspect I am
pushing at the boundaries of what backpack can nicely do. But at least
for the moment I couldn't see a nicer way. Suggestions welcome!

* Fix 'InsufficientWitnesses' predicate.
teodanciu pushed a commit to bienpulenta/cardano-ledger that referenced this pull request Apr 19, 2023
…ll-stack

Add more HasCallStack and withFrozenCallStack to test helpers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants