-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haskell/merge/simple utxo delegation #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step, merge data-structures from delegation into simple UTxO model. Make UTxO model compile and tests pass.
Refactor `Coin` into its own module to prevent cyclic dependencies. Adapt types in `LedgerState`.
This replaces the UTF operators for domain restriction and exclusion and for UTxO union via ASCII approximations and the named function `union`. I think it is much easier to get an editor to represent those in a nicer way than it is to enter them via their UTF code.
JaredCorduan
approved these changes
Oct 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JaredCorduan
pushed a commit
that referenced
this pull request
Feb 12, 2019
* Organise 'Ledger.Abstract' module. * Create simple and witnessed ledgers. The composition here is not especially nice - I suspect I am pushing at the boundaries of what backpack can nicely do. But at least for the moment I couldn't see a nicer way. Suggestions welcome! * Fix 'InsufficientWitnesses' predicate.
kevinhammond
added a commit
that referenced
this pull request
Oct 28, 2019
# This is the 1st commit message: Merge branch 'spec/incentives-kh' of https://github.com/input-output-hk/cardano-ledger-specs into spec/incentives-kh # This is the commit message #2: overcoming fake make error Signed-off-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com> # This is the commit message #3: overcoming fake make error Signed-off-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com> # This is the commit message #4: overcoming fake make error Signed-off-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com> # This is the commit message #5: overcoming fake make error Signed-off-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com> # This is the commit message #6: overcoming fake make error Signed-off-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com> # This is the commit message #7: fix user.email Signed-off-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com> # This is the commit message #8: overcoming fake make error Signed-off-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com> # This is the commit message #9: overcoming fake make error Signed-off-by: Kevin Hammond <12563287+kevinhammond@users.noreply.github.com>
nc6
added a commit
that referenced
this pull request
May 19, 2020
* Organise 'Ledger.Abstract' module. * Create simple and witnessed ledgers. The composition here is not especially nice - I suspect I am pushing at the boundaries of what backpack can nicely do. But at least for the moment I couldn't see a nicer way. Suggestions welcome! * Fix 'InsufficientWitnesses' predicate.
teodanciu
pushed a commit
to bienpulenta/cardano-ledger
that referenced
this pull request
Apr 19, 2023
…ll-stack Add more HasCallStack and withFrozenCallStack to test helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the current delegation code into the simple UTxO Haskell model.
This required some refactoring and some things are only made type correct, e.g.
AddrTxin
in the hspec tests.