Update dependencies on consensus and ledger #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoutts
requested review from
erikd,
intricate,
mrBliss and
newhoggy
as code owners
|
@CodiePP perhaps you can enlighten me. |
|
@mrBliss This also depends on a one-liner in consensus |
mrBliss
reviewed
Jul 15, 2020
| @@ -168,78 +168,78 @@ source-repository-package | |||
| source-repository-package | |||
| type: git | |||
| location: https://github.com/input-output-hk/cardano-ledger-specs | |||
| tag: 6611345670dad971fbd03594a00b5ef8afa4cae6 | |||
| --sha256: 0rhdlf7kz62231127ywbakhsgsxhhkba5gz24dfy7l9r45a1ijkk | |||
| tag: 47e2075f751d8370222a2aad32f37699a341ec40 | |||
There was a problem hiding this comment.
I was planning to update the dependency on cardano-ledger-specs today, now that IntersectMBO/cardano-ledger#1664 is merged.
Is that alright or does that perhaps breaking changes that are not wanted?
There was a problem hiding this comment.
@nc6 is working on this already.
There was a problem hiding this comment.
More than one update is fine. Yes we'll need to do it again to get the latest ledger changes.
Merged
A couple tracers gained some extra warning fields.
dcoutts
force-pushed
the
dcoutts/update-deps
branch
from
c9e4810
to
8691083
Compare
|
bors merge |
|
👎 Rejected by too few approved reviews |
mrBliss
approved these changes
Jul 15, 2020
Comment on lines
330
to
334
| -- Text.concat [ "\nWarning: " <> formatText w o | w <- ws ] | ||
| --TODO: we could trace these warnings but then a | ||
| -- HasTextFormatter (LedgerWarning blk) constraint will propagate everywhere | ||
| -- and it's not clear that's how it's supposed to work, since we don't have any | ||
| -- other HasTextFormatter constraints floating around |
There was a problem hiding this comment.
I haven't looked at this in detail, but would show work for now?
dcoutts
force-pushed
the
dcoutts/update-deps
branch
from
8691083
to
75b1e5b
Compare
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 15, 2020
1465: Update dependencies on consensus and ledger r=dcoutts a=dcoutts A couple tracers gained some extra warning fields. Log the new ledger warnings Only properly supported for the JSON logging, not for the human readable, since I can't quite see how it's supposed to be done without HasTextFormatter constaints propagating everywhere, which does not seem to be the intended pattern. Co-authored-by: Duncan Coutts <duncan@well-typed.com>
Build failed |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple tracers gained some extra warning fields. Log the new ledger
warnings
Only properly supported for the JSON logging, not for the human
readable, since I can't quite see how it's supposed to be done without
HasTextFormatter constaints propagating everywhere, which does not seem
to be the intended pattern.