Include KES metrics in cardano #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was ignoring the KES data from Shelley previously, leading to #1448.
Using a patch in `ouroboros-network` that exports a function that we need to access the Shelley ForgeState from a Cardano block.
kantp
requested review from
dcoutts,
erikd,
intricate,
Jimbo4350,
mrBliss and
newhoggy
as code owners
intricate
approved these changes
Jul 20, 2020
edsko
approved these changes
Jul 21, 2020
Co-authored-by: Luke <19835357+intricate@users.noreply.github.com>
kantp
force-pushed
the
philipp/kes-metrics-in-cardano
branch
from
4f70e2e
to
f8d73db
Compare
|
bors merge |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
HasKESMetricsDatainstance for the Cardano protocol, to include the KES metrics from Shelley.Still need confirmation from @disassembler that it actually has the desired effect on #1448