Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-106: Add encoder and decoder for LedgerState #3993

Merged
merged 1 commit into from
Feb 8, 2023
Merged

PLT-106: Add encoder and decoder for LedgerState #3993

merged 1 commit into from
Feb 8, 2023

Conversation

zliu41
Copy link
Member

@zliu41 zliu41 commented Jun 3, 2022

One use case is for foldBlocks to checkpoint the ledger state to avoid having to start from Genisys. cc @JaredCorduan

@JaredCorduan
Copy link
Contributor

It would be absolutely wonderful to have foldBlocks be able to checkpoint the ledger state! I'm not certain that such encodings don't already exist somewhere else in this repoo, but @Jimbo4350 probably knows.

@zliu41
Copy link
Member Author

zliu41 commented Jun 3, 2022

I'm not certain that such encodings don't already exist somewhere else in this repo

Yeah I saw an existing encodeTelescope in the ouruboros-consensus repo, so I should be able to reuse that.

@zliu41 zliu41 marked this pull request as draft June 3, 2022 14:38
@zliu41 zliu41 marked this pull request as ready for review June 3, 2022 15:55
@zliu41
Copy link
Member Author

zliu41 commented Jun 3, 2022

Updated!

@zliu41 zliu41 changed the title Add encoder and decoder for LedgerState PLT-106: Add encoder and decoder for LedgerState Jun 7, 2022
JaredCorduan
JaredCorduan approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zliu41 zliu41 mentioned this pull request Sep 28, 2022
Merged
@zliu41 zliu41 force-pushed the serialise/ledgerstate branch 2 times, most recently from 6e8c1f2 to b17a066 Compare December 6, 2022 18:56
@zliu41 zliu41 force-pushed the serialise/ledgerstate branch 2 times, most recently from a336bc4 to c2716d2 Compare February 7, 2023 21:19
@zliu41
Copy link
Member Author

zliu41 commented Feb 7, 2023

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 7, 2023

👎 Rejected by code reviews

@zliu41
Copy link
Member Author

zliu41 commented Feb 7, 2023

bors try

iohk-bors bot added a commit that referenced this pull request Feb 7, 2023
@iohk-bors
Try #3993:
e61d6b0
@JaredCorduan
Copy link
Contributor

@zliu41 I think @Jimbo4350 's lock is still on this PR...

@zliu41
Copy link
Member Author

zliu41 commented Feb 7, 2023

@zliu41 I think @Jimbo4350 's lock is still on this PR...

Yep! I'm working on merging the other PR first, and will come back to this one.

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 8, 2023

try

Timed out.

Jimbo4350
Jimbo4350 reviewed Feb 8, 2023
View reviewed changes
cardano-api/src/Cardano/Api/LedgerState.hs Outdated
@@ -52,6 +54,8 @@ module Cardano.Api.LedgerState
)
where

import qualified Codec.CBOR.Decoding as CBOR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use: import qualified Cardano.Binary as CBOR

@zliu41
Copy link
Member Author

zliu41 commented Feb 8, 2023

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 8, 2023
@iohk-bors @zliu41
Merge #3993
e209cd6 
3993: PLT-106: Add encoder and decoder for `LedgerState` r=zliu41 a=zliu41

One use case is for `foldBlocks` to checkpoint the ledger state to avoid having to start from Genisys. cc `@JaredCorduan` 

Co-authored-by: Ziyang Liu <unsafeFixIO@gmail.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 8, 2023

Timed out.

@zliu41
Copy link
Member Author

zliu41 commented Feb 8, 2023

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 8, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit 94b0341 into IntersectMBO:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@JaredCorduan JaredCorduan JaredCorduan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zliu41 @JaredCorduan @Jimbo4350