Windows CI builds #4590
Windows CI builds #4590
Conversation
newhoggy
force-pushed
the
newhoggy/fix-windows-builds
branch
18 times, most recently
from
316e01c
to
60ffc02
Compare
newhoggy
changed the title
newhoggy
force-pushed
the
newhoggy/fix-windows-builds
branch
from
60ffc02
to
bca5635
Compare
|
bors r+ |
|
Can I suggest that we leave a comment explaining why this is doing what it's doing? Otherwise we will lose the knowledge and it will just make our pipelines even more obscure and hard to modify! |
|
bors r- |
|
Canceled. |
| @@ -178,7 +179,7 @@ jobs: | |||
| sed -i 's|tests: False|tests: True|g' cabal.project | |||
| fi | |||
|
|
|||
| cp .github/workflows/cabal.project.local.ci cabal.project.local | |||
| cp ".github/workflows/cabal.project.local.ci.$(uname -s)" cabal.project.local | |||
There was a problem hiding this comment.
For Windows only, we need to pass extra flags so that gcc and ld (which ghc invokes) can find the libraries and header files.
This is necessary because unfortunately the 3rdparty msys2 system we use installs packages into D:/a/_temp/msys64/mingw64 instead of the system C:\msys64\mingw64. This applies also the secp256k1.
It's unclear why gcc and ld invoked by ghc is unable to see this alternate installation directory.
To make it easy so treat Windows differently, we have OS specific cabal.project.local.ci.* files which are copied to cabal.project.local.
The additional flags to make this work on Windows can then be put into cabal.project.local.ci.MINGW64_NT-10.0-20348
Please see the linked issue for more information.
|
|
||
| package cardano-crypto-praos | ||
| extra-include-dirs: D:/a/_temp/msys64/mingw64/include | ||
| extra-lib-dirs: D:/a/_temp/msys64/mingw64/lib |
There was a problem hiding this comment.
Any Haskell packages that fails to build because the system installation directory is missing will need an entry here. This ought to only happen with packages that have C bindings to system libraries that are only installed in the alternate package installation directory.
.github/workflows/haskell.yml
Outdated
| @@ -57,6 +57,7 @@ jobs: | |||
| mingw-w64-x86_64-toolchain | |||
| mingw-w64-x86_64-libsodium | |||
| mingw-w64-x86_64-jq | |||
| mingw-w64-x86_64-openssl | |||
There was a problem hiding this comment.
It's unclear if I need this, but I added because HsOpenSSL was the first package that was failing to build..
Once this is merged I will try to remove the openssl and see if it still builds.
There was a problem hiding this comment.
It seems it worked fine without installing openssl in ouroboros-network.
|
@coot seems to be addressing the same problems here, perhaps worth comparing notes? IntersectMBO/ouroboros-network#4134 |
|
@newhoggy pointed me to his PR, and I copied the solution. |
newhoggy
force-pushed
the
newhoggy/fix-windows-builds
branch
from
bca5635
to
e8af02a
Compare
|
bors r+ |
|
Build succeeded: |
4612: Cardano Node 1.35.6 aka Single Relay P2P release r=coot a=coot Update `ouroboros-network-0.2.0.0`. This also cherry-picked CI commits: * e745ca8 from #4184 * #4513 * #4526 * #4590 Co-authored-by: Michael Peyton Jones <michael.peyton-jones@iohk.io> Co-authored-by: Marcin Szamotulski <coot@coot.me>
Resolves #4614