Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on some traces by default #5353

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Turn on some traces by default #5353

merged 2 commits into from
Jun 28, 2023

Conversation

coot
Copy link
Contributor

@coot coot commented Jun 21, 2023

No description provided.

@coot coot changed the title Turn on by default some traces Turn on some traces by default Jun 21, 2023
dnadales
dnadales approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@dnadales dnadales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should document somewhere how to turn these tracers off in the config file, because it does not seem obvious.

@coot coot force-pushed the coot/default-tracers branch from 3c401b7 to 23cd06d Compare June 21, 2023 10:12
@coot coot requested a review from a team as a code owner June 21, 2023 10:53
coot added 2 commits June 21, 2023 16:10
@coot
Turn on some traces by default
b2d955c 
`node-to-node` traces:
* `TraceServer`

`node-to-client` traces:
* `TraceLocalConnectionManager`
* `TraceLocalhandshake`
* `TraceLocalInboundGovernor`
* `TraceLocalServer`
@coot
topology.json docs: link to the right place
7eb6675
@coot coot force-pushed the coot/default-tracers branch from fc671f7 to 7eb6675 Compare June 21, 2023 14:12
@dnadales dnadales mentioned this pull request Jun 27, 2023
Closed
@coot coot added this pull request to the merge queue Jun 28, 2023
Merged via the queue into master with commit ad4a89a Jun 28, 2023
@iohk-bors iohk-bors bot deleted the coot/default-tracers branch June 28, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnadales dnadales dnadales approved these changes

Assignees
No one assigned
Labels
cardano-node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coot @dnadales