Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardano-node 9.1.0 release #5910

Merged

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Jul 17, 2024

  • Remove declaration of protocol version 8
  • reports 9.1 in block header
  • cardano-cli -> 9.0.0.1
  • adds final conway genesis for preview/preprod/mainnet

Description

  • Make specification of Conway genesis file mandatory again
  • Remove possibility of declaring protocol version 8 in Conway era

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@Jimbo4350 Jimbo4350 requested a review from a team as a code owner July 17, 2024 13:40
@Jimbo4350 Jimbo4350 force-pushed the jordan/revert-non-failure-if-conway-genesis-missing branch from 16f181d to 91ea104 Compare July 17, 2024 13:45
@disassembler disassembler requested review from a team as code owners July 23, 2024 05:44
@disassembler disassembler force-pushed the jordan/revert-non-failure-if-conway-genesis-missing branch 5 times, most recently from 198b3cd to 293e1f9 Compare July 23, 2024 20:54
@disassembler disassembler requested a review from a team as a code owner July 23, 2024 21:08
@disassembler disassembler force-pushed the jordan/revert-non-failure-if-conway-genesis-missing branch from 37a8432 to e091269 Compare July 23, 2024 21:09
@disassembler disassembler changed the title Make specification of Conway genesis file mandatory again Cardano-node 9.1.0 release Jul 23, 2024
@disassembler disassembler force-pushed the jordan/revert-non-failure-if-conway-genesis-missing branch 2 times, most recently from 98ca11c to 6505cb6 Compare July 23, 2024 21:24
@disassembler disassembler force-pushed the jordan/revert-non-failure-if-conway-genesis-missing branch 3 times, most recently from df56cb1 to fd4579e Compare July 24, 2024 05:38
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disassembler disassembler force-pushed the jordan/revert-non-failure-if-conway-genesis-missing branch from fd4579e to 2b15ee6 Compare July 24, 2024 13:02
@disassembler disassembler force-pushed the jordan/revert-non-failure-if-conway-genesis-missing branch from 2b15ee6 to ad7286d Compare July 24, 2024 16:12
@disassembler disassembler merged commit 176f99e into master Jul 24, 2024
13 of 16 checks passed
@disassembler disassembler deleted the jordan/revert-non-failure-if-conway-genesis-missing branch July 24, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants