Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network tracing instances for fetch decisions #6061

Open
wants to merge 1 commit into
base: nm/release-srp
Choose a base branch
from

Conversation

coot
Copy link
Contributor

@coot coot commented Dec 28, 2024

Description

  • Provide instances for FetchDecisionEvent for new tracing
    system.
  • Provide ToJSON instances for FetchDecision (via
    FetchDecisionToJSON newtype wrapper), TraceDecisionEvent, Point
    which can be used by both new and old tracing system.
  • Provide Verbose newtype wrapper wich ToJSON instances provide more
    verbose output.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

* Provide instances for `FetchDecisionEvent` for new tracing
  system.
* Provide `ToJSON` instances for `FetchDecision` (via
  `FetchDecisionToJSON` newtype wrapper), `TraceDecisionEvent`, `Point`
  which can be used by both new and old tracing system.
* Provide `Verbose` newtype wrapper wich `ToJSON` instances provide more
  verbose output.
@coot coot requested a review from a team as a code owner December 28, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant