Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check-changelogs.sh is looking for changelog.d in the wrong directory #1347

Closed
nfrisby opened this issue Dec 18, 2024 · 0 comments · Fixed by #1348
Closed

check-changelogs.sh is looking for changelog.d in the wrong directory #1347

nfrisby opened this issue Dec 18, 2024 · 0 comments · Fixed by #1348
Labels
continuous integration

Comments

@nfrisby
Copy link
Contributor

nfrisby commented Dec 18, 2024

PR #1342 happily changed the script to ignore unstable source code.

But the whitelist of stable source code is also incorrectly being used to determine where the changelog.d fragment is.
@nfrisby nfrisby moved this to 👀 In review in Consensus Team Backlog Dec 18, 2024
nfrisby added a commit that referenced this issue Dec 18, 2024
@nfrisby
check-changelogs.sh: bugfix
cd52d3c 
Fixes #1347
@nfrisby nfrisby mentioned this issue Dec 18, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 18, 2024
@nfrisby
check-changelogs.sh: bugfix (#1348)
592e11c 
Fixes #1347
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Consensus Team Backlog Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
continuous integration
Projects
Consensus Team Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check-changelogs.sh: bugfix IntersectMBO/ouroboros-consensus
1 participant
@nfrisby