Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend leftover changelogs from previous release #1266

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Amend leftover changelogs from previous release #1266

merged 1 commit into from
Sep 26, 2024

Conversation

jasagredo
Copy link
Contributor

In particular we broke PVP in ouroboros-consensus-diffusion as there were breaking changes.

amesgen
amesgen approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

FTR: These are exactly the changelog entries that were erroneously not incorporated in #1207

The only exception is ouroboros-consensus-protocol/changelog.d/20240207_130614_fraser.murray_startup_sanity_checks.md which documented a change that didn't actually made it into #874.

@jasagredo jasagredo enabled auto-merge September 26, 2024 09:47
@jasagredo jasagredo added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit dc2cf9a Sep 26, 2024
18 checks passed
@jasagredo jasagredo deleted the js/amend-changelogs branch September 26, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amesgen amesgen amesgen approved these changes

@nfrisby nfrisby Awaiting requested review from nfrisby nfrisby is a code owner

@fraser-iohk fraser-iohk Awaiting requested review from fraser-iohk fraser-iohk is a code owner

@dnadales dnadales Awaiting requested review from dnadales dnadales is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasagredo @amesgen